Conversation
BillCarsonFr
added
the
Z-NextRelease
bmarty
requested changes
Jun 11, 2021
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
Thanks for the improvement of the alias input rendering, it's much better now :)
Some remark after a static review.
...id/src/main/java/org/matrix/android/sdk/internal/session/room/DefaultRoomDirectoryService.kt
Show resolved
Hide resolved
...ix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/RoomDirectoryService.kt
Outdated
Show resolved
Hide resolved
...main/java/org/matrix/android/sdk/internal/session/room/alias/RoomAliasAvailabilityChecker.kt
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/form/FormEditTextItem.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceViewModel.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceViewModel.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceViewModel.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceViewModelTask.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/spaces/manage/SpaceSettingsController.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/spaces/manage/SpaceSettingsController.kt
Outdated
Show resolved
Hide resolved
|
I think this would be great in various other places like the sign-up/sign-in flow, to reduce confusion about whether the prefix (@ or #) needs to be included etc. |
BillCarsonFr
force-pushed
the
feature/bca/spaces_alias
branch
from
200ca65 to
f836e56
Compare
bmarty
approved these changes
Jun 16, 2021
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
Thanks for the update.
There is a conflict to fix, also some minor change to do (copyright)
...sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/AliasAvailabilityResult.kt
Outdated
Show resolved
Hide resolved
...id/src/main/java/org/matrix/android/sdk/internal/session/room/DefaultRoomDirectoryService.kt
Show resolved
Hide resolved
...main/java/org/matrix/android/sdk/internal/session/room/alias/RoomAliasAvailabilityChecker.kt
Show resolved
Hide resolved
Member
|
the file |
BillCarsonFr
force-pushed
the
feature/bca/spaces_alias
branch
from
f836e56 to
4180b4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3483
Uses prefix/suffix of textInputLayout instead of custom form alias item